Why some people say Local Variables are bad...

[Ray.R]

Still needs some work...

[Ray.R]

Below is part of the Locals abuse...

Abusing Local Variables by using them as container of data or to change the data values can lead to race conditions.  It is not necessary to use Locals to change the value of a variable, since the variable is the wire itself.  It is better to chage the value to the wire and use a state machine to update the display of the value.  Only this portion of the code was  shown, but looking at the entire code makes it difficult to understand the intent of the coder.  So in this perspective, abusing Locals makes it difficulr to read and unsderstand the code.

found here:  http://forums.ni.com/ni/board/message?board.id=170&view=by_date_ascending&message.id=401019#M401019

Message Edited by Ray.R on 04-12-2009 08:14 PM

Message Edited by Ray.R on 04-12-2009 08:19 PM

[Ray.R]

From: http://forums.ni.com/ni/board/message?board.id=170&thread.id=411529

Quoting smercurio: "Your code suffers from the dual-condition we here like to call "sequencitis" and "local variablitis". Text-based programmers would absolutely love your code. LabVIEW programmers, on the other hand, would have a heart attack."

[Wayne.C]

Ray,

Based on the use of the large words in the diagnosis, I believe its now 'Dr. smercurio'.  Wonder what his bill is going to look like?

[Ray.R]

It won't be cheap... Because he's a Specialist, and not a General Practitioner..  😉

[altenbach]

The first identification of this pandemic was reported over two years ago. Still, there is no vaccine in sight 😞

Exessive contact with text based code if often considered a mitigating factor.

Abstinence from text based code and large doses of vitamin G are the only known remedies.

It is somewhat contageous and quaratine in a suitable LabVIEW forum is strongly advised.

😄

[Wayne.C]

Here is a small slice of a big problem found here.  http://forums.ni.com/ni/board/message?board.id=170&thread.id=414838

Message Edited by Wayne.C on 06-09-2009 08:18 AM

[Ray.R]

It is allowed to run a wire from one frame of a flat sequence to the next frame (or anywhere outside the frame).  It is not necessary to use Local Variables.

[altenbach]

---

Ray.R wrote:

It is allowed to run a wire from one frame of a flat sequence to the next frame (or anywhere outside the frame).  It is not necessary to use Local Variables.

---

A more serious issue is the fact that there are three pairs of controls having the same name. Looking at the image, there is no way to tell if the second frame ever gets any new data. 😄

I am also puzzled with using comparison operations on strings. That sounds like a minefield to me. 😮

[Ray.R]

That's a good name for Locals.... minefields..  😉