CLD Traffic Light Sample Exam.

[VI_Joe]

I am posting my solution for the CLD Traffic Light Sample Exam.  Comments and input is appreciated.  The main VI is Traffic Lite.vi.

Thanks in advance.

[VENKATESH.J]

Hi Joe,

Here are my preliminary suggestions...

1. I would suggest to use Get time/Date in seconds instead of Tick count for finding elapsed time.

Reason: http://digital.ni.com/public.nsf/allkb/6F6B9F4E149C80578625652800784764

2. When you hit the stop button,it should react within 100ms.

3. Document each programming structure with a brief description of its functionality

    Label wires to show the data on the wire and the direction of data flow

    Label constants with names that represent their functions

Reason: Because CLD has good weightage in documentation part.So concentrate on it.

[jcarmody]

Nice work, VI Joe.  I heve just a few comments.  The first two will get you more points from the judges, the third is personal style preference.

1. Add descriptions and tip strips to your controls (and indicators).
   
   
2. You go to either Idle or Display from almost every state; poll the controls before your main Case Structure executes and update the indicators afterwards instead.  You wouldn't need to use a State Queue any more if you did this.
   1. This would also get your Stop button to work as required.  As VENKATESH.J mentioned, it needs to respond immediately.
      
      
3. This is a cleaner way to queue up multiple states:
   
   
   

[Islandman]

This is a nit, but your left turn is pointing right.

[LV_Pro]

This is the UPS turn efficiency traffic light system