Carwash problem Review

[salemb]

Hey, I'm an undergraduate student and pretty new to LabVIEW. Recently practiced the car wash problem for the sake of practicing and also used an existing FGV Timer for the time being and also added a TCP/IP logging element as well. Would appreciate for someone to give me their opinion or critique of my block diagram logic and UI?

Thanks.

[ZYOng]

Most of the forum users don't have the latest version of LabVIEW. Please Saving for a Previous Version, preferably 2019.

[salemb]

Thanks for letting me know, I wasn't aware. Below is the same project file saved to the 2019 version (19.0).

[ZYOng · Accepted solution]

Your VIs are saved in 2019 but the project is in 2024.

In the future, you can save the entire project for the previous version from project explorer.

My recommendations:

1. Always make the State Enum a type def. 
2. Never use Stop to abort an execution, unless it is a last resort. Stop the loop properly to ensure cleanup steps are carried out. Even though you don't have any cleanup steps in your code, you should make it a good practice.
3. Timer FGV: You don't need to force the value of Time Elapsed to Target Time. You can refer to FGV Timer SubVI

4. The VI will not be stopped if the Start button has not been pressed.

5. You can use explicit reference and for loops to disable multiple controls more efficiently. Save the reference of all controls to a cluster and use when needed.

6. If you are preparing for CLD, you are not allowed to modify or add any controls or indicators, even if they are hidden.

7. For your TCP Server VI, again you shouldn't use Abort to stop the VI. Use a Stop button or Panel Close event to stop VI gracefully.