LabVIEW
How to looping my code
Solved!
Hi,
Use the For Loop structure with shift register, and an insert into array function inside it.
Regards,
Gita
@jvc.dossantos wrote:
I have this code attached and I need the code repeats N times. Where N is the number of images that I need to process. Every time the program start, I need that a new image to be processed and the data have to be write in a matrix. So each row of my final matrix has to contain the data processed. Until now in the VI i have two image being processed, but I'm rewriting all the code for each image. I want a looping where I have just write one time.
As has been said, you really need to start with a few tutorials.
Converting to U8, then to a matrix, then to DBL (which it already is), then to a 2D array, then to a matrix indicator then back to a matrix and back to a 2D U8 array is pure madness. You can skip most of these steps, they simply don't make any sense. In LabVIEW, a matrix is a special typedef'd datatype most useful for lienar algebra. You are not doing linear algebra, so all you need are 2D arrays.
Also, typically if you have two arrays in the native U8 range , then multiply them, and convert the result back to U8, will cause a lot of data loss because of overflow. The product ot two U8 number can cover the full U16 range!
The result will probably not be very useful. Can you explain in more generic terms what you are trying to do?
How do you want the result to be arranged in the 2D array?
OK, so you have an array of images and an matching array of masks (or you can make an array out of the paths).
The images are 24bit RGB images and the masks are 4 bit images. Are the masks just 0 or 1?
When you convert a 24bit RGB image to U8, you are throwing away a singificant amount of information. What is the logic behind it?
In any case, if the mas is just 0,1, you can just multiply the two raw blue arrays. You don't need any orange of any kind anywhere. Drop all these meaningless conversions.
So you are transposing the 2D arrays and the reshape them to a 1D array and are removing all elements that are zero. Most likely, the two images you are processing contain a different amount of zeroed elements, so when you build these 1D arrays back into a 2D array with 2 rows (drop the matrix operations already!), the shorter array will get padded with zeroes. Is that really what you want?
At the end you are summing all the elements. Since the zero elements don't contribute to the sum, you don't really need to remove them so you can also skip the reshaping. Also transposing does not make a difference.
You end up with a 1D array, so why are you converting again to a matrix???
In any case, here's how you would process such arrays of matching images and mask paths, give about the same result (please verify!) as what you were doing. This should give you some ideas. As I said, converting a 24 bit RGB image to U8 seems incorrect. Modify as needed.
- Stop using matrix datatypes! I never want to hear the word matrix again in this thread! All you need is 2D arrays. Big difference! If the values don't look right, check the formatting of the indicators.
- Don't duplicate all that code. Exactly one instance of the code is needed, place it in a FOR loop. What if you need to process 1000 files next time? Would you create code the size of a football field??? 😮
- A FOR loop with a 1 wired to N can be deleted. It does not serve any purpose. All it does is turn your 2D array into a 3D array by the misguided autoindexing output tunnel. Completely useless and severly complicate the code later.
- Converting to U8 is not the correct way to turn a 24 bit Greyscale image in RGB format into a 8 bit greyscale image
- Why are you using the color table of the mask to save the masked image. Makes no sense.
- Have you even looked at my suggestion? It will probably get you close. Autoindex over an array of paths and use one instance of the code! If you want to keep the 2D arrays, don't do the summing, but reshape to 1D. It will turn into a 2D array with one row for each image at the autoindexing output tunnel. Transpose if needed.
- Do some LabVIEW tutorials. Your code is not reasonable and shows that you have very little to no undestanding of LabVIEW. You first need to learn the basics.
