Terminating two independent while loops

[bsvare]

The majority of the last bit of rube can also be simplified:

[Ranjeet_Singh]

Hi crossrulz

------------------------------------------------------------------------------------------------------------------------------------------------------------------------

crossrulz wrote:

[...]

On a serious note:  What is the second loop supposed to be doing?  The way I see it, you already have all the information you need in the first loop.  I don't see a point in your second loop.

------------------------------------------------------------------------------------------------------------------------------------------------------------------------

After i read status command response i need to show all data to user. After i read successfully i need to wait for user to press exit from front panel. Becasue user take some time to analyse all the datas. second while loop for that only. Thats why termination condition are either error occured or exit pressed by user.

[Ranjeet_Singh]

Hi crossrulz

Your reply for that

------------------------------------------------------------------------------------------------------------------------------------------------------

Lets not go for reduction of code inside first while loop,i tried already

------------------------------------------------------------------------------------------------------------------------------------------------------

I got this idea before but i did this becasue in other project size of store rate,scan rate varies and i kept it general.

This doesnt make any difference

[Ranjeet_Singh]

Hi GerdW,

                       I also can go for this but the placement of all the status strings in the front panel is not same hence i need to read the bits like this only. I cant use array.

One more thing, how you are printing the code in this style. i saw this in many places. Any shortcut method for that ? 

[Ranjeet_Singh]

Hi bsvare, 

                        Tell me how can i simplify. All the property node is for different controls. Please post your simplified version.

Thanks

[Ranjeet_Singh]

Hi crossrulz,

                       Thanks for your concern. see the response of different elements is not of fixed size as some are 2,4,6,16,18 bytes. This is better becasue in future if it changes also only thing i need to modify is index. if i simply drag that then next time i need to see from the starts. In my other projects this is different. So i tried to keep this general.

[Mark_Yedinak]

There are many ways you can implement your code and still have a much less rube style of code. You do understand that you are ignoring the advice of some of the top LabVIEW programmers on the forums. Rather than debate with them that your bad code is the only way to do things try to listen to their advice and learn how to improve your code.

[Ranjeet_Singh]

Dear Mark_Yedinak,

                                     I always want to learn,Tell me where i can reduce my code ?

I am not debating with my SIRs, See they are replying me with modification and i am replying them with my answer that 'This is the reason becasue of this i am doing like this'.

This is not debate, see if at last i will be proved wrong then i will learn something. This is discussion for learning not FIGHTING or DEBATE.

[James_W]

Ranjeet,

You seem to have missed the fundamental point that all the Gurus are trying to give you. Simplify how you process the code cand do one function for all items of the same type (that way if you have it wrong it is easier to correct, it is easier for others to read, and the code is smaller.) THEN when the data is processed, in it's final form you can have your propery nodes/ indicators or whatever you need to update. It's much easier to keep the code seperate that way.

Standard NI Mantra:

1) Aquire

2) Anaylse (Process Data)

3) Present (Display Processed Data to user)