What do you guys think about my traffic lights code (see attached vi)?

[GRCK5000]

I want constructive criticism.  I know I have a lot of case structures, but I know someone in this forum can get this done with a single while loop and couple of logics. His first name starts with C and last name starts with A. Those who know, knows who I am talking about.

But what do you think about what I have accomplished? I am so happy that I've learned a lot. Soon I will no longer be a baby programmer. Thanks God!

Feel free to share how you would do yours. Let's do code demonstration of simple stuff. 

[altenbach]

• Try to do it without any local variables. None are needed!
• No need to get timestamps because you are only interested in differences. Replace it with "high resolution relative seconds"
• Your case structure after the loop can never be false, so it is just a glorified sequence frame.
• traffic lights don't need a 10ms resolution.
• Your "obj" control should be a diagram constant, not a hidden control. Give it a better name because the term "object" has a special meaning in programming.
• Since Exactly one LED is true at any given time, use a radiobutton control for it (see here for example), greatly simplifying things.
• etc.

[altenbach]

• In a typical traffic light, the red is on top and the green on the bottom, so please rearrange that.
• You can eliminate all that duplicate code. If you need to really keeping your 9 states, all you need is three cases. (In fact, you only need three states, see my linked code above)
• No need for locals!

See attached for a quick literal rewrite. Make sure you understand it fully.

[paul_cardinale]

In the US, the middle light is usually referred to as 'yellow'.  Also, the green is more of a blue-green.  The actual chromaticity ranges are specified by law (but I couldn't find them); however I've adjusted the colors to make them a bit closer.

I've also attached an old traffic light control that I made years ago.

[GRCK5000]

Thanks Mr. Altenbach! These are very good advice. Also, I like how simple you made it look, using only 3 cases. I knew it would be a piece of cake for you. lol.

I have a question about what you did here: https://forums.ni.com/t5/LabVIEW/PUT-TIMER-AT-TRAFFIC-LIGHT/m-p/4046577#M1160741

How are you able to insert booleans (G, Y, R) in enum? How did you do that?

[GRCK5000]

Thank you, Mr. Paul_cardinale, for your input. Good to know!

[billko]

I wish every LabVIEW developer were as enthusiastic as you.

[paul_cardinale]

---

@GRCK5000 wrote:

Thanks Mr. Altenbach! These are very good advice. Also, I like how simple you made it look, using only 3 cases. I knew it would be a piece of cake for you. lol.

I have a question about what you did here: https://forums.ni.com/t5/LabVIEW/PUT-TIMER-AT-TRAFFIC-LIGHT/m-p/4046577#M1160741

How are you able to insert booleans (G, Y, R) in enum? How did you do that?

---

That's a radio buttons control (q.v.)

[altenbach]

---

@GRCK5000 wrote:

How are you able to insert booleans (G, Y, R) in enum? How did you do that?

---

A radiobutton container (boolean palette) is similar to a cluster, but it can only contain booleans. Any style and number of booleans!!!!

Only exactly one (or also none of so configured) can be TRUE at any given time, As soon as another one turns true, all others turn false automatically. This is very useful and often dramatically simplifies your code.

In your case, you would place a radiobutton control from the palette, then drop your three LEDs in it. Now you can remove the two booleans that were originally in there. You can change the cluster order if needed. Of course you can make it a control (typical) or an indicator (as in this case).

The type is an enum with values for all element names in cluster order. The current value of the enum is the label of the element that is currently true, so make sure all elements have unique and clear labels, even if they don't show on the front panel.

( Also have a look at my description here and vote for it if you like. 😄 )

[GRCK5000]

🤣 I just love what I do. Accomplishment brings even more happiness. Thanks God!