LabVIEW
Abnormal diagram horizontal streching
I'm experiencing some problem with block "Cleanup Diagram", for some reason inside some block this's the result of a cleanup..
Hi Michele,
@michele.santucci wrote:
I'm experiencing some problem with block "Cleanup Diagram", for some reason inside some block this's the result of a cleanup..
And what is the problem?
Nobody said that Autocleanup will produce "nice" looking diagram.
All it does is enhancing really bad looking diagrams...
Why are there so many local variables in this small part of the code?
> Why are there so many local variables in this small part of the code?
to avoid wires messing up with the soooo stretched diagram.
If the wires are short are pretty easy to follow .. with such a streching it becomes harder.
Anyway as you can see.. in the same Vi (another block):
pretty much the same elements are 'cleaned up' properly and also here there are many (redundant) local variables.
Hi Michele,
@michele.santucci wrote:
to avoid wires messing up with the soooo stretched diagram.
If the wires are short are pretty easy to follow .. with such a streching it becomes harder.
To avoid long wires you should use more subVIs!
Why do you need so many sequence frames? Why don't you "OBEY DATAFLOW!" to enforce dataflow?
This will also reduce the length of your wires...
@michele.santucci wrote:
I'm experiencing some problem with block "Cleanup Diagram", for some reason inside some block this's the result of a cleanup..
It is not clear if this is a flat or stacked sequence structure. If it is a stacked sequence structure there might be code in the other frame(s) which need the space.
Sometimes it helps to perform "Cleanup Diagram" multiple times or to select a structure and perform the cleanup only on this structure.
@michele.santucci wrote:
> Why are there so many local variables in this small part of the code?
to avoid wires messing up with the soooo stretched diagram.
If the wires are short are pretty easy to follow .. with such a streching it becomes harder.
Anyway as you can see.. in the same Vi (another block):
If the wires are short and terminate in local variables, we cannot "follow the wire" to see where the data comes from and where it is going and where it was modified last. There is no way to tell in what order locals are read or written unless you segment all code with sequence structures (as you do), making things even much uglier. This severely limits compiler optimizations because you prevent it from doing any parallelization while forcing it to shuffle data to the front panel and back.
And as has been said, diagram cleanup should never be used on reasonable code. It will make truly bad code slightly more readable, but will make any reasonably good code worse. I never ever use it on my own code, but sometimes use it on code downloaded from the forum.
In any case, a truncated picture is insufficient to make your point because we cannot really tell what else is there. Also note that cleanup is not idempotent, thus the result typically changes when applied several times in a row. What happens if you click cleanup twice or more?
Hi Michele,
@michele.santucci wrote:
I'm reclutant to undergo deep modifications to preserve what's working but in some case I think it will be mandatory.
I recommend to use (or setup) a SCC system (source code control), like SVN or GIT.
This will help you significantly to handle revisions/version of your code base!
