LabVIEW
Repeated sequence in a case structure
Solved!
OK, you code is still a jungle with way too much duplicate code. Here's a quick draft how it could be organized better, eliminating duplicate code and using arrays wherever possible.
(This was modified blidly, so there are probably quite a few errors. I cannot test. Modify as needed).
Some points:
- Write to spreadsheet file is inefficient, because it opens and closes the file with each call. Open the file once and append using lowlevel functions instead. Close file when the loop is done.
- Writing the tick count to a file is pointless. It is random. Either calculate the elapsed time from [i] or use relative tick counts.
- Shouldn't the "recod initial mass" button be latch action?
- You should probably place the wait on the toplevel loop diagram.
- Controls belong on the toplevel loop diagram, not inside case structures (performance issue)
- Are you sure the subtraction is correct? Shouldn't the inputs be reversed.
- All your communications are sequential, so don't run them in parallel.
- If you show the digital display of the chart, you can eliminate the "output 1" indicator. same thing!
- You could re-use the valve controls also as indicators, eliminating the green LEDs. (update them via a local variable as needed).
- last edited on by
Content Cleaner
The tick count outputs a U32 value that represents the number of milliseconds elapsed since the sytem has started. once it runs out of numbers it starts again from zero. Unless you start your program exactly after a defined time after the computer has started, the value will be random.
In order to get elapsed time, you need to take the difference of two tick values.
I am trying to understand your revision and learning a lot from it. I would be very happy if you could answer the following questions:
1 - You put a delay for the main loop, but this also reduces the data frequency of the balance. I just want to put a delay to adjust the on/off interval of the valves. In this case, shouldn't it be in the case structure (i.e., Case#2)?
2 - The "for loops" are used to write data to Arduino pins. How many times are they executed ? I see that "N" is not defined.
3 - 255/80 is valid for 2 pins of Arduino but one of them should be 255/130. How would you change this?
4 - In Case#2, you created a 1D boolean array and it looks nice but I cannot do it that way? How did you do that? (see the picture)
- Your delay inside the case will delay the entire outer loop whenever that case is active, making the outer loop rate variable. How fast do you really need to read the data? If you want to toggle at a different rate, you need to use a seperate loop.
- They execute for each element in the autoindexing array. No need to wire N. The number of iterations is fully determined by the shortest autoindexing array input. LabVIEW 101!
- You can create an array of calibration factors and autoindex over them instead. same difference (See picture for an example).
- What can't you do it that way? Drop an empty array container on the diagram and drop a boolean diagram constant into it. Set all desired elements to the desire value..
