collecting data and storing into an array using a sub VI

[JohmDoe86]

I am using a VISA READ function to get measurements out of a DMM.

Every time i run the program i get a different number. Everything works perfect up to that point.

now i have a subVi to be able to store the data one after the other everytime i take a measurement so that i can ultimately insert it into excel.

it is not working as i intend, what am i doing wrong?

[pincpanter]

Don't wire the constant to the shift register left terminal, because this will empty the SR at each call.

Also, remark that "Read" is actually "Read and initialize". Consider a change to the operation name.

[JohmDoe86]

i removed it and still have the same issue.

And about the change to the operation name, what do you suggest?

[altenbach · Accepted solution]

• Please (please!) do not maximize the front panels and diagrams to the screen. Super annoying!
• Your DMM code does not have a toplevel loop, you should make it a state machine instead
• Your subVI needs to complete after one iteration, so don't use a stop button
• The read mode needs the array wired across to be non-destructive
• Terminals need to be on the toplevel diagram, not inside structures
• Use a standard connector pane.
• If you want to just record successive runs to a file, just append to a file. No need for subVIs. (this also ensure that all data collected so far exists, even if the computer crashes later)
• Use reasonable terminal names ("array" is not descriptive enough.
• To get an empty array, just do "use default if unwired" in the init case.
• do. some. beginner. tutorial.
• etc.

[pincpanter]

First: wire a true constant to the While Loop stop terminal. Any operation must only be done once.

Second: connect the right terminal to your output (now it's the emptied shift register).