LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

Connecting 2 cases

Solved!
Go to solution

Im sorry but based on your code , i still can lock and unlock the door without the correct password . That's not right

0 Kudos
Message 11 of 22
(1,527 Views)
Solution
Accepted by mrspaceman

Try something like this (lock and unlock buttons need to be pressed until the door has reached the end state).

Since the number buttons are latch action, one of them is always true and the inner case is not really needed.

 

 

0 Kudos
Message 12 of 22
(1,518 Views)

really appreciated your help but the point is the door need to be automated with 1 press

0 Kudos
Message 13 of 22
(1,514 Views)

Guys, I do not wanna be too rigorous, but you are close to give a final solution of a home work I think. The OP should really start learning more LV basics, and not waiting for a final solution 🙂

0 Kudos
Message 14 of 22
(1,507 Views)
Solution
Accepted by mrspaceman

@mrspaceman wrote:

really appreciated your help but the point is the door need to be automated with 1 press


Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing one

----------------------------------------------------------------------------------------------------------------
Palanivel Thiruvenkadam | பழனிவேல் திருவெங்கடம்
LabVIEW™ Champion |Certified LabVIEW™ Architect |Certified TestStand Developer

Kidlin's Law -If you can write the problem down clearly then the matter is half solved.
-----------------------------------------------------------------------------------------------------------------
0 Kudos
Message 15 of 22
(1,502 Views)

I have FOUND THe answer . THanks to all of your help here . It's the first time i post and ask for help  . Feel amazed by all of your help and kindness. God bless you all . Wish you all a good week 

Smiley Wink

0 Kudos
Message 16 of 22
(1,489 Views)

@palanivelthiruvenkadam@gmail.com wrote:
Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing one

There is still a lot of Rube Goldberg code in there.

  • The number buttons should be latch action, so one is guaranteed to be true if the event fires, simplifying the code.
  • There is still no reason for the timeout case.
  • That case structure with 9 cases and 9 diagram constants is very hard to maintain. See my code for an alternative
  • The fedback node is still wired incorrectly. Don't use the previous value to calculate the other displays, but the current value.
  • Should one be able to lock without password or do both lock and unlock need it?

 

0 Kudos
Message 17 of 22
(1,482 Views)

@altenbach wrote:

@palanivelthiruvenkadam@gmail.com wrote:
Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing one

There is still a lot of Rube Goldberg code in there.

  • The number buttons should be latch action, so one is guaranteed to be true if the event fires, simplifying the code.
  • There is still no reason for the timeout case.
  • That case structure with 9 cases and 9 diagram constants is very hard to maintain. See my code for an alternative
  • The fedback node is still wired incorrectly. Don't use the previous value to calculate the other displays, but the current value.
  • Should one be able to lock without password or do both lock and unlock need it?

 


Thanks for the comments. and i went through your code  and looks good take your comments

Provided solution from his own code to to build his confidence that his code works to some extent.

If i try to build a code hope it will answer all your questions

----------------------------------------------------------------------------------------------------------------
Palanivel Thiruvenkadam | பழனிவேல் திருவெங்கடம்
LabVIEW™ Champion |Certified LabVIEW™ Architect |Certified TestStand Developer

Kidlin's Law -If you can write the problem down clearly then the matter is half solved.
-----------------------------------------------------------------------------------------------------------------
0 Kudos
Message 18 of 22
(1,477 Views)
Solution
Accepted by mrspaceman

Some general comments:

 

Try to use a radiobutton for the operation to avoid the case where both buttons are true.

Instead of using case structures, you can just disable controls if they should not be operated. Better feedback to the user.

 

Here's a quick modification

Message 19 of 22
(1,466 Views)

It's perfect the solution from you . Thank you so much . 

0 Kudos
Message 20 of 22
(1,449 Views)