05-30-2016 09:16 AM
Im sorry but based on your code , i still can lock and unlock the door without the correct password . That's not right
05-30-2016 09:32 AM - edited 05-30-2016 09:33 AM
Try something like this (lock and unlock buttons need to be pressed until the door has reached the end state).
Since the number buttons are latch action, one of them is always true and the inner case is not really needed.
05-30-2016 09:35 AM
really appreciated your help but the point is the door need to be automated with 1 press
05-30-2016 09:43 AM
Guys, I do not wanna be too rigorous, but you are close to give a final solution of a home work I think. The OP should really start learning more LV basics, and not waiting for a final solution 🙂
05-30-2016 09:48 AM
@mrspaceman wrote:really appreciated your help but the point is the door need to be automated with 1 press
Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing one
05-30-2016 09:58 AM
I have FOUND THe answer . THanks to all of your help here . It's the first time i post and ask for help . Feel amazed by all of your help and kindness. God bless you all . Wish you all a good week
05-30-2016 10:11 AM
@palanivelthiruvenkadam@gmail.com wrote:
Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing one
There is still a lot of Rube Goldberg code in there.
05-30-2016 10:17 AM
@altenbach wrote:
@palanivelthiruvenkadam@gmail.com wrote:
Will be good if u try to some extent to get answer, still please find the attached vi and try to think different from the existing oneThere is still a lot of Rube Goldberg code in there.
- The number buttons should be latch action, so one is guaranteed to be true if the event fires, simplifying the code.
- There is still no reason for the timeout case.
- That case structure with 9 cases and 9 diagram constants is very hard to maintain. See my code for an alternative
- The fedback node is still wired incorrectly. Don't use the previous value to calculate the other displays, but the current value.
- Should one be able to lock without password or do both lock and unlock need it?
Thanks for the comments. and i went through your code and looks good take your comments
Provided solution from his own code to to build his confidence that his code works to some extent.
If i try to build a code hope it will answer all your questions
05-30-2016 11:02 AM - edited 05-30-2016 11:03 AM
Some general comments:
Try to use a radiobutton for the operation to avoid the case where both buttons are true.
Instead of using case structures, you can just disable controls if they should not be operated. Better feedback to the user.
Here's a quick modification
05-30-2016 12:33 PM
It's perfect the solution from you . Thank you so much .